Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix go mod problem #583

Closed
wants to merge 2 commits into from
Closed

fix go mod problem #583

wants to merge 2 commits into from

Conversation

liubog2008
Copy link

See #581

@CLAassistant
Copy link

CLAassistant commented Jun 19, 2019 •
edited

CLA assistant check
All committers have signed the CLA.

@liubog2008 liubog2008 mentioned this pull request Jul 12, 2019
Closed
This was referenced Jul 18, 2019
Closed
Merged
@Helcaraxan
Copy link
Contributor

FWIW. There is a more recent PR (#605) that should be preferred here as it upgrades to a more recent version of go-critic that contains other relevant fixes as well.

@Helcaraxan Helcaraxan mentioned this pull request Aug 29, 2019
Closed
@jirfag
Copy link
Member

jirfag commented Sep 9, 2019

sorry for the slow response and thank you for the pull request, I will merge #605 and close it

@jirfag jirfag closed this Sep 9, 2019
@liubog2008 liubog2008 deleted the fix-mod branch September 10, 2019 02:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@liubog2008 @CLAassistant @Helcaraxan @jirfag