Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

build(deps): bump github.com/nunnatsa/ginkgolinter from 0.14.1 to 0.15.0 #4246

Conversation

dependabot[bot]
Copy link
Contributor

@dependabot dependabot bot commented on behalf of github Dec 10, 2023

Bumps github.com/nunnatsa/ginkgolinter from 0.14.1 to 0.15.0.

Release notes

Sourced from github.com/nunnatsa/ginkgolinter's releases.

v0.15.0

What's Changed

New rule(s): Wrong Usage of the MatchError gomega Matcher

The MatchError gomega matcher asserts an error value (and if it's not nil).

There are four valid formats for using this Matcher:

  • error value; e.g. Expect(err).To(MatchError(anotherErr))
  • string, to be equal to the output of the Error() method; e.g. Expect(err).To(MatchError("Not Found"))
  • A gomega matcher that asserts strings; e.g. Expect(err).To(MatchError(ContainSubstring("Found")))
  • [from v0.29.0] a function that receive a single error parameter and returns a single boolean value. In this format, an additional single string parameter, with the function description, is also required; e.g. Expect(err).To(MatchError(isNotFound, "is the error is a not found error"))

These four format are checked on runtime, but sometimes it's too late. ginkgolinter performs a static analysis and so it will find these issues on build time.

ginkgolinter checks the following:

  • Is the first parameter is one of the four options above.
  • That there are no additional parameters passed to the matcher; e.g. MatchError(isNotFoundFunc, "a valid description" , "not used string"). In this case, the matcher won't fail on run time, but the additional parameters are not in use and ignored.
  • If the first parameter is a function with the format of func(error)bool, ginkgolinter makes sure that the second parameter exists and its type is string.

Full Changelog: nunnatsa/ginkgolinter@v0.14.1...v0.15.0

Commits
  • 68080f0 Bump golang.org/x/tools from 0.15.0 to 0.16.0
  • ddfad26 Bump golang.org/x/tools from 0.14.0 to 0.15.0
  • 289fb3c New rule(s): Wrong Usage of the MatchError gomega Matcher
  • See full diff in compare view

Dependabot compatibility score

Dependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting @dependabot rebase.


Dependabot commands and options

You can trigger Dependabot actions by commenting on this PR:

  • @dependabot rebase will rebase this PR
  • @dependabot recreate will recreate this PR, overwriting any edits that have been made to it
  • @dependabot merge will merge this PR after your CI passes on it
  • @dependabot squash and merge will squash and merge this PR after your CI passes on it
  • @dependabot cancel merge will cancel a previously requested merge and block automerging
  • @dependabot reopen will reopen this PR if it is closed
  • @dependabot close will close this PR and stop Dependabot recreating it. You can achieve the same result by closing it manually
  • @dependabot show <dependency name> ignore conditions will show all of the ignore conditions of the specified dependency
  • @dependabot ignore this major version will close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself)
  • @dependabot ignore this minor version will close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it yourself)
  • @dependabot ignore this dependency will close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself)

@dependabot dependabot bot added dependencies Relates to an upstream dependency go Pull requests that update Go code labels Dec 10, 2023
@ldez ldez added the linter: update version Update version of linter label Dec 10, 2023
@ldez ldez self-requested a review December 10, 2023 11:42
Bumps [github.com/nunnatsa/ginkgolinter](https://github.com/nunnatsa/ginkgolinter) from 0.14.1 to 0.15.0.
- [Release notes](https://github.com/nunnatsa/ginkgolinter/releases)
- [Commits](nunnatsa/ginkgolinter@v0.14.1...v0.15.0)

---
updated-dependencies:
- dependency-name: github.com/nunnatsa/ginkgolinter
  dependency-type: direct:production
  update-type: version-update:semver-minor
...

Signed-off-by: dependabot[bot] <support@github.com>
@dependabot dependabot bot force-pushed the dependabot/go_modules/github.com/nunnatsa/ginkgolinter-0.15.0 branch from dfbb21a to c244ffa Compare December 10, 2023 11:43
@ldez ldez added the blocked Need's direct action from maintainer label Dec 10, 2023
@ldez
Copy link
Member

ldez commented Dec 10, 2023

This PR is blocked because the linter uses go1.21.
https://github.com/nunnatsa/ginkgolinter/blob/68080f06de2ca816ca1c035b5599750b38bb9d80/go.mod#L3

@nunnatsa
Copy link
Contributor

@ldez - just released ginkgolinter v0.15.1, built with go1.20

Copy link
Contributor Author

dependabot bot commented on behalf of github Dec 10, 2023

Superseded by #4248.

@dependabot dependabot bot closed this Dec 10, 2023
@dependabot dependabot bot deleted the dependabot/go_modules/github.com/nunnatsa/ginkgolinter-0.15.0 branch December 10, 2023 14:08
@ldez ldez added declined and removed blocked Need's direct action from maintainer labels Dec 10, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
declined dependencies Relates to an upstream dependency go Pull requests that update Go code linter: update version Update version of linter
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants