dev: remove github.com/pkg/errors inside tests #3642
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ldez
added
topic: cleanup
ldez
force-pushed
the
fix/clean-pkg-errors
branch
from
196b9af
to
4acedd4
Compare
SeigeC
pushed a commit
to SeigeC/golangci-lint
that referenced
this pull request
Apr 4, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I completely remove
github.com/pkg/errorsfrom tests because the files inside tests are not considered to create the go.mod.So when the latest dependency will remove
github.com/pkg/errors, and then this package will be removed from the go.mod, a lot of tests will fail.The latest dependency that uses
github.com/pkg/errorsisforbidigoand the dependency will be removed inside PR #3639.