.golangci.reference.yml validation #3613
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
govet cannot have both disable-all+enable and enable-all+disable.
This ensures that changes made to the reader don't break parsing of the reference configuration.
|
Hello, sorry but the reference can not be handled like that. I don't think we need to validate the reference, and the reference by the exhaustivity is invalid by nature. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I recently (see #3612) worked on configuration changes that touched the reader. I found no unit test for it, so I added one with the
.golangci.reference.ymlfile as input.The positive side effect is that putting something invalid there now gets flagged during testing. The negative effect is that invalid configuration entries must be commented out, which makes it a bit less readable.