Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

dev: remove stable from actions/setup-go #3055

Merged
merged 2 commits into from Aug 4, 2022
Merged

dev: remove stable from actions/setup-go #3055

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
498f91a
ci/gha: remove stable from actions/setup-go
kolyshkin Aug 3, 2022
4758343
reveiw
ldez Aug 4, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
5 changes: 3 additions & 2 deletions .github/workflows/post-release.yml
View file
Open in desktop
Expand Up @@ -14,9 +14,10 @@ jobs:
- name: Install Go
uses: actions/setup-go@v3
with:
# Keep the following comment to be able to use rc and beta version of Go (ex: 1.18.0-rc.1).
# https://github.com/actions/setup-go#supported-version-syntax
# stable: 'false'
# ex:
# - 1.18beta1 -> 1.18.0-beta.1
# - 1.18rc1 -> 1.18.0-rc.1
go-version: 1.19

- name: Update GitHub action config
Expand Down
5 changes: 3 additions & 2 deletions .github/workflows/pr-extra.yml
View file
Open in desktop
Expand Up @@ -13,9 +13,10 @@ jobs:
- uses: actions/checkout@v3
- uses: actions/setup-go@v3
with:
# Keep the following comment to be able to use rc and beta version of Go (ex: 1.18.0-rc.1).
# https://github.com/actions/setup-go#supported-version-syntax
# stable: 'false'
# ex:
# - 1.18beta1 -> 1.18.0-beta.1
# - 1.18rc1 -> 1.18.0-rc.1
go-version: 1.19
- name: Run go list
run: go list -json -m all > go.list
Expand Down
30 changes: 18 additions & 12 deletions .github/workflows/pr.yml
View file
Open in desktop
Expand Up @@ -16,9 +16,10 @@ jobs:
- name: Install Go
uses: actions/setup-go@v3
with:
# Keep the following comment to be able to use rc and beta version of Go (ex: 1.18.0-rc.1).
# https://github.com/actions/setup-go#supported-version-syntax
# stable: 'false'
# ex:
# - 1.18beta1 -> 1.18.0-beta.1
# - 1.18rc1 -> 1.18.0-rc.1
go-version: ${{ env.GO_VERSION }}
- name: Checkout code
uses: actions/checkout@v3
Expand All @@ -36,9 +37,10 @@ jobs:
- name: Install Go
uses: actions/setup-go@v3
with:
# Keep the following comment to be able to use rc and beta version of Go (ex: 1.18.0-rc.1).
# https://github.com/actions/setup-go#supported-version-syntax
# stable: 'false'
# ex:
# - 1.18beta1 -> 1.18.0-beta.1
# - 1.18rc1 -> 1.18.0-rc.1
# go-version: ${{ env.GO_VERSION }} # todo(ldez) uncomment after the next release v1.48.0
go-version: 1.18
- name: lint
Expand All @@ -57,9 +59,10 @@ jobs:
- name: Install Go
uses: actions/setup-go@v3
with:
# Keep the following comment to be able to use rc and beta version of Go (ex: 1.18.0-rc.1).
# https://github.com/actions/setup-go#supported-version-syntax
# stable: 'false'
# ex:
# - 1.18beta1 -> 1.18.0-beta.1
# - 1.18rc1 -> 1.18.0-rc.1
go-version: ${{ env.GO_VERSION }} # test only the latest go version to speed up CI
- name: Run tests
run: make.exe test
Expand All @@ -73,9 +76,10 @@ jobs:
- name: Install Go
uses: actions/setup-go@v3
with:
# Keep the following comment to be able to use rc and beta version of Go (ex: 1.18.0-rc.1).
# https://github.com/actions/setup-go#supported-version-syntax
# stable: 'false'
# ex:
# - 1.18beta1 -> 1.18.0-beta.1
# - 1.18rc1 -> 1.18.0-rc.1
go-version: ${{ env.GO_VERSION }} # test only the latest go version to speed up CI
- name: Run tests
run: make test
Expand All @@ -93,9 +97,10 @@ jobs:
- name: Install Go
uses: actions/setup-go@v3
with:
# Keep the following comment to be able to use rc and beta version of Go (ex: 1.18.0-rc.1).
# https://github.com/actions/setup-go#supported-version-syntax
# stable: 'false'
# ex:
# - 1.18beta1 -> 1.18.0-beta.1
# - 1.18rc1 -> 1.18.0-rc.1
go-version: ${{ matrix.golang }}
- uses: actions/cache@v3
with:
Expand All @@ -119,9 +124,10 @@ jobs:
- name: Install Go
uses: actions/setup-go@v3
with:
# Keep the following comment to be able to use rc and beta version of Go (ex: 1.18.0-rc.1).
# https://github.com/actions/setup-go#supported-version-syntax
# stable: 'false'
# ex:
# - 1.18beta1 -> 1.18.0-beta.1
# - 1.18rc1 -> 1.18.0-rc.1
go-version: ${{ env.GO_VERSION }}
- name: Check generated files are up to date
run: make fast_check_generated
10 changes: 6 additions & 4 deletions .github/workflows/tag.yml
View file
Open in desktop
Expand Up @@ -14,9 +14,10 @@ jobs:
- name: Install Go
uses: actions/setup-go@v3
with:
# Keep the following comment to be able to use rc and beta version of Go (ex: 1.18.0-rc.1).
# https://github.com/actions/setup-go#supported-version-syntax
# stable: 'false'
# ex:
# - 1.18beta1 -> 1.18.0-beta.1
# - 1.18rc1 -> 1.18.0-rc.1
go-version: 1.19
- name: Unshallow
run: git fetch --prune --unshallow
Expand All @@ -43,9 +44,10 @@ jobs:
- name: Install Go
uses: actions/setup-go@v3
with:
# Keep the following comment to be able to use rc and beta version of Go (ex: 1.18.0-rc.1).
# https://github.com/actions/setup-go#supported-version-syntax
# stable: 'false'
# ex:
# - 1.18beta1 -> 1.18.0-beta.1
# - 1.18rc1 -> 1.18.0-rc.1
go-version: 1.19

- name: Unshallow
Expand Down