Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

make gci linter fixable #2653

Closed
wants to merge 4 commits into from
Closed

make gci linter fixable #2653

wants to merge 4 commits into from

Conversation

vasyharan
Copy link

Fixes #2604

@boring-cyborg
Copy link

boring-cyborg bot commented Mar 17, 2022

Hey, thank you for opening your first Pull Request !

@CLAassistant
Copy link

CLAassistant commented Mar 17, 2022 •
edited

CLA assistant check
All committers have signed the CLA.

@ldez ldez added blocked Need's direct action from maintainer linter: update Update the linter implementation inside golangci-lint labels Mar 17, 2022
@vasyharan vasyharan closed this Mar 18, 2022
@vasyharan
Copy link
Author

sorry about the noise. i was figuring out how to get the workflow to run on my fork to address test failures. this should be addressed now (vasyharan#1 had a successful run)

@vasyharan vasyharan reopened this Mar 18, 2022
@ldez
Copy link
Member

ldez commented Mar 18, 2022

We have to approve the run of the workflow because it's your first contribution.
So the CI will not start, it will start when we will allow it.

https://docs.github.com/en/actions/managing-workflow-runs/approving-workflow-runs-from-public-forks

@vasyharan
Copy link
Author

anything i can help with / do to unblock this?

@killianmuldoon killianmuldoon mentioned this pull request Mar 30, 2022
Closed
@barweiss
Copy link

Hi @vasyharan, @ldez!
Is there any way to help with this issue?

@hilariocoelho
Copy link

@ldez can you have a look on this please? :)

@alexandear alexandear requested a review from ldez April 28, 2022 20:47
@nightlyone nightlyone mentioned this pull request May 19, 2022
Open
@daixiang0
Copy link
Contributor

@vasyharan please fix conflicts.

@ldez ldez mentioned this pull request May 30, 2022
Merged
@ldez
Copy link
Member

ldez commented May 30, 2022

closed in favor of #2892

@ldez ldez closed this May 30, 2022
@ldez ldez added declined and removed blocked Need's direct action from maintainer labels May 30, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ldez ldez Awaiting requested review from ldez

Assignees
No one assigned
Labels
declined linter: update Update the linter implementation inside golangci-lint
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Add autofix for gci
6 participants
@vasyharan @CLAassistant @ldez @barweiss @hilariocoelho @daixiang0