Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

importas: allow repeated aliases #1960

Merged
merged 2 commits into from May 8, 2021
Merged

importas: allow repeated aliases #1960

merged 2 commits into from May 8, 2021

Commits on May 8, 2021

  1. Allow repeated importas aliases 

    The standalone importas takes arguments in the form "{package}:{alias}"
and stores them in a map in which package is the key. The intent is to
describe the one alias that is appropriate for a unique package path.

We cannot use the package path as a map key due to Viper's dot notation.
Instead use a list with package/alias pairs.
    @cbandy
    cbandy committed May 8, 2021
    Copy the full SHA
    eb65ac6 View commit details
    Browse the repository at this point in the history

  2. review: throw en error when the package is empty

    @ldez
    ldez committed May 8, 2021
    Copy the full SHA
    2565820 View commit details
    Browse the repository at this point in the history