Flip importas configuration #1959
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The standalone importas takes arguments in the form "{package}:{alias}"
and stores them in a map in which package is the key. The intent is to
describe the one alias that is appropriate for a unique package path.
This aligns our configuration with the standalone tool.
|
Hey, thank you for opening your first Pull Request ! |
|
|
|
Hello, It's not possible to flip the configuration due to the configuration parsing system. It's related to viper spf13/viper#324 |
ldez
added
blocked
|
I see. Are you open to changing it to a list of strings? These match how the standalone tool works exactly. importas:
# if set to `true`, force to use alias.
no-unaliased: true
# List of aliases
aliases:
# using `servingv1` alias for `knative.dev/serving/pkg/apis/serving/v1` package
- knative.dev/serving/pkg/apis/serving/v1:servingv1
# using `autoscalingv1alpha1` alias for `knative.dev/serving/pkg/apis/autoscaling/v1alpha1` package
- knative.dev/serving/pkg/apis/autoscaling/v1alpha1:autoscalingv1alpha1
# You can specify the package path by regular expression,
# and alias by regular expression expansion syntax like below.
# see https://github.com/julz/importas#use-regular-expression for details
- knative.dev/serving/pkg/apis/(\w+)/(v[\w\d]+):$1$2 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The standalone importas tool takes arguments in the form
{package}:{alias}and stores them in a map in whichpackageis the key. The intent is to describe the one alias that is appropriate for a unique package path.The golangci-lint configuration does the opposite; the
aliasis the key. This effectively "reserves" an alias for one package. This difference in configuration limits the number of packages that can be configured and doesn't align with the goals and documentation of the standalone tool.This PR aligns our configuration with the standalone tool. It is a breaking change, but another breaking change to this linter's configuration is waiting to be released in ffe8061.