Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

importas: add message if settings contain no aliases #1956

Merged
merged 1 commit into from May 6, 2021
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
3 changes: 3 additions & 0 deletions pkg/golinters/importas.go
Expand Up @@ -24,6 +24,9 @@ func NewImportAs(settings *config.ImportAsSettings) *goanalysis.Linter {
if settings == nil {
return
}
if len(settings.Alias) == 0 {
lintCtx.Log.Infof("importas settings found, but no aliases listed. List aliases under alias: key.") // nolint: misspell
}

err := analyzer.Flags.Set("no-unaliased", strconv.FormatBool(settings.NoUnaliased))
if err != nil {
Expand Down
4 changes: 4 additions & 0 deletions test/testdata/configs/importas_noalias.yml
@@ -0,0 +1,4 @@
linters-settings:
importas:
fff: fmt
std_os: os
15 changes: 15 additions & 0 deletions test/testdata/importas_noalias.go
@@ -0,0 +1,15 @@
//args: -Eimportas
//config_path: testdata/configs/importas_noalias.yml
package testdata

import (
wrong_alias "fmt"
"os"
wrong_alias_again "os"
)

func ImportAsNoAlias() {
wrong_alias.Println("foo")
wrong_alias_again.Stdout.WriteString("bar")
os.Stdout.WriteString("test")
}