Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

update go-critic to v0.5.6 #1925

Merged
merged 3 commits into from May 1, 2021
Merged

update go-critic to v0.5.6 #1925

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
e53c402
update go-critic to v0.5.6
pierrre Apr 22, 2021
ebe629d
review
ldez Apr 22, 2021
2ec529e
review
ldez Apr 22, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
2 changes: 1 addition & 1 deletion go.mod
View file
Open in desktop
Expand Up @@ -18,7 +18,7 @@ require (
github.com/esimonov/ifshort v1.0.2
github.com/fatih/color v1.10.0
github.com/fzipp/gocyclo v0.3.1
github.com/go-critic/go-critic v0.5.5
github.com/go-critic/go-critic v0.5.6
github.com/go-xmlfmt/xmlfmt v0.0.0-20191208150333-d5b6f63a941b
github.com/gofrs/flock v0.8.0
github.com/golangci/check v0.0.0-20180506172741-cfe4005ccda2
Expand Down
11 changes: 5 additions & 6 deletions go.sum
View file
Open in desktop

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

7 changes: 4 additions & 3 deletions pkg/golinters/govet_test.go
View file
Open in desktop
Expand Up @@ -18,9 +18,10 @@ import (

func TestGovet(t *testing.T) {
// Checking that every default analyzer is in "all analyzers" list.
checkList := append(defaultAnalyzers,
shadow.Analyzer, // special case, used in analyzersFromConfig
)
var checkList []*analysis.Analyzer
checkList = append(checkList, defaultAnalyzers...)
checkList = append(checkList, shadow.Analyzer) // special case, used in analyzersFromConfig

for _, defaultAnalyzer := range checkList {
found := false
for _, a := range allAnalyzers {
Expand Down