Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update errcheck #1582

Closed
wants to merge 2 commits into from
Closed

Conversation

leventov
Copy link
Contributor

@leventov leventov commented Dec 27, 2020

Note that I removed checker.UpdateNonVendoredIgnore() call.

Test fail in test/testdata/errcheck.go, IgnoreStdxWrite() function:

func IgnoreStdxWrite() {
	os.Stdout.Write([]byte{})
	os.Stderr.Write([]byte{})
}

Not sure how to fix this (and how did it work before the change).

Related to kisielk/errcheck#185

Depend on #1319

@SVilgelm @sayboras could you please review?

@boring-cyborg
Copy link

boring-cyborg bot commented Dec 27, 2020

Hey, thank you for opening your first Pull Request !

@CLAassistant
Copy link

CLAassistant commented Dec 27, 2020

CLA assistant check
All committers have signed the CLA.

@ldez ldez changed the title Update errcheck after https://github.com/kisielk/errcheck/pull/185 is merged Update errcheck Dec 27, 2020
@ldez ldez added the linter: update version Update version of linter label Dec 27, 2020
@ldez
Copy link
Member

ldez commented Dec 27, 2020

Hello @leventov,

As your PR point to an old branch, I'm not sure that we will be able to merge without bypassing the CI.

So I cherry-picked your commit and rebase the branch of #1319.

Thank you very much 👍

@ldez ldez closed this Dec 27, 2020
@ldez ldez removed the linter: update version Update version of linter label Dec 27, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants