Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

docs: Add description of Homebrew's official formula #1421

Merged
merged 3 commits into from Nov 7, 2020
Merged

docs: Add description of Homebrew's official formula #1421

Changes from 1 commit
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
41cef21
docs: Add description of Homebrew's official formula
rinsuki Oct 9, 2020
4465e1e
Update index.mdx
rinsuki Nov 7, 2020
9ab2c1f
Merge branch 'master' into patch-1
rinsuki Nov 7, 2020
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
7 changes: 7 additions & 0 deletions docs/src/docs/usage/install/index.mdx
View file
Open in desktop
Expand Up @@ -53,6 +53,13 @@ brew install golangci/tap/golangci-lint
brew upgrade golangci/tap/golangci-lint
```

If you don't want to use tap, official formula also available. but it requires install Go compiler from Homebrew, so be careful.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is valid change, indeed but could you:

  • delete section that mentions the tap above (it isn't maintained anymore)
  • do not mention obsolete tap in your change?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It looks like the tap is still being maintained, is there any information anywhere that the tap is obsolete?
https://github.com/golangci/homebrew-tap/commits/master

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Huh, I guess we keep it for backward compatibility reason or because we missed the fact that tap is still being upgraded. Removing it from the docs sounds like a good idea to me anyway.


```sh
brew install golangci-lint
brew upgrade golangci-lint
```

### Docker

```sh
Expand Down