Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use lowercase directories to fix test #1229

Merged
merged 1 commit into from
Jul 11, 2020
Merged

Conversation

jwilner
Copy link
Contributor

@jwilner jwilner commented Jul 11, 2020

#1226 appears to have introduced a test failure into master via a combination of factors.

My current theory:

  1. A test refers to a test data directory in camel-case, but the directory isn't actually camel-case
  2. This camel-case test passed locally for me because MacOS's fs is case-insensitive
  3. This test somehow did not run on the PR build
  4. It finally ran against master where the fs was not case-insensitive

Success in PR -- TestPathPrefix is nowhere present

Failure in master
image

@jwilner
Copy link
Contributor Author

jwilner commented Jul 11, 2020

Passing now in latest run:
image

@jwilner
Copy link
Contributor Author

jwilner commented Jul 11, 2020

The erroneously passing PR build above seems to not be building the correct commit.

It says it's checking out the commit c0121d51:

commit 83277cb66eb0f68ec40b336ee55ee9c626970e13
Date:   Thu Jul 9 23:49:10 2020 -0500

    Merge c0121d51bfcb007eae86fac87fba5ea3b6bf2f26 into 916213c5968d710e9f00407feb58024105ce6457

But it's supposed to be building on 2dca06e -- the next commit... I'm disturbed.

Copy link
Member

@SVilgelm SVilgelm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me. Thank you

@SVilgelm
Copy link
Member

I'm merging to unblock the CI

@SVilgelm SVilgelm merged commit 60abe4a into golangci:master Jul 11, 2020
@ldez ldez added this to the v1.28 milestone Mar 6, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants