update go-critic to v0.5.6

[pierrre]

Fix #1923

[ldez]

go-ruleguard uses strconv.ParseComplex, this function was introtuced in go1.15.

Our CI, run with go1.14, go1.15, go1.16, then it's an issue with go1.14.

$ go build -o golangci-lint ./cmd/golangci-lint
go: downloading github.com/go-critic/go-critic v0.5.6
go: downloading github.com/quasilyte/go-ruleguard v0.3.4
# github.com/quasilyte/go-ruleguard/internal/gogrep
Error: ../../../go/pkg/mod/github.com/quasilyte/go-ruleguard@v0.3.4/internal/gogrep/match.go:677:13: undefined: strconv.ParseComplex
note: module requires Go 1.15
make: *** [Makefile:61: golangci-lint] Error 2
Error: Process completed with exit code 2.

[pierrre]

What should we do ?

I look at the previous code, and the older version of go-ruleguard was not using strconv.ParseComplex(). (it was not parsing complex at all)

Is there a problem to update the minimum Go version required for golangci-lint ?
Is it a problem for people who run golangci-lint as a command line ?

[ldez]

I need time to think about it.

[ldez]

LGTM

[golangci-automator]

Hey, @pierrre — we just merged your PR to golangci-lint! 🔥🚀

golangci-lint is built by awesome people like you. Let us say “thanks”: we just invited you to join the GolangCI organization on GitHub.
This will add you to our team of maintainers. Accept the invite by visiting this link.

By joining the team, you’ll be able to label issues, review pull requests, and merge approved pull requests.
More information about contributing is here.

Thanks again!