Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

golint will be deprecated #1892

Closed
sanposhiho opened this issue Apr 5, 2021 · 7 comments · Fixed by #1965
Closed

golint will be deprecated #1892

sanposhiho opened this issue Apr 5, 2021 · 7 comments · Fixed by #1965
Labels
dependencies Relates to an upstream dependency enhancement New feature or improvement

Comments

@sanposhiho
Copy link
Member

sanposhiho commented Apr 5, 2021

Sorry if this issue is duplicated

golint is(will be) deprecated.

This proposal - to freeze and deprecate x/lint - is accepted.
golang/go#38968

Describe the solution you'd like

deprecate golint like interfacer.
#1755

@sanposhiho sanposhiho added the enhancement New feature or improvement label Apr 5, 2021
@ldez ldez added the dependencies Relates to an upstream dependency label Apr 5, 2021
@sanposhiho
Copy link
Member Author

sanposhiho commented Apr 5, 2021

If no one else has started implementing it, I want to pick this issue

@sanposhiho sanposhiho self-assigned this Apr 5, 2021
@ldez
Copy link
Member

ldez commented Apr 5, 2021

@sanposhiho Please don't deprecate golint for now.

We have to think more about it.

@ldez
Copy link
Member

ldez commented Apr 5, 2021

The proposal has been accepted but no action has been taken on this subject, at least there is nothing on the golint repository and no official announcement.

I think it can be a good idea before the deprecation to wait for the actions of the Go team.

@sanposhiho
Copy link
Member Author

sanposhiho commented Apr 6, 2021

I think it can be a good idea before the deprecation to wait for the actions of the Go team.

okey 👍

@james-johnston-thumbtack

The repository has been archived, and it's most definitely dead. golangci-lint should mark it as deprecated.

My 5 minute Google search suggests that Revive looks like a suitable drop-in replacement...?

@sanposhiho
Copy link
Member Author

sanposhiho commented May 14, 2021

Hello
Sorry, I have one thing to discuss, so let me reopen it for a while.

Golint README uses staticcheck and go vet as an example of an alternative tool.
Shouldn't we recommend staticcheck or govet as an alternative instead of revive?

NOTE: Golint is deprecated and frozen. There's no drop-in replacement for it, but tools such as Staticcheck and go vet should be used instead.

https://github.com/golang/lint

@sanposhiho sanposhiho reopened this May 14, 2021
@ldez
Copy link
Member

ldez commented May 14, 2021

Golint is deprecated and frozen. There's no drop-in replacement for it, but tools such as Staticcheck and go vet should be used instead.

The most important information is "There's no drop-in replacement for it".

I'm sorry, there is no officially recommended lint tool. You should choose a lint tool that will work well for your project. staticcheck is a fine choice.

golang/go#38968 (comment)

go vet and staticcheck are currently not the closest linters to replace golint.

go vet doesn't contain passes that are comparable to golint, I think they mean that you can implement new passes for go vet.

I think that the Go team doesn't really know the Go linters world.

The closest linter to golint is revive.

@ldez ldez closed this as completed May 14, 2021
caboteria added a commit to epic-gateway/eds-server that referenced this issue Sep 9, 2023
caboteria added a commit to epic-gateway/eds-server that referenced this issue Sep 9, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
dependencies Relates to an upstream dependency enhancement New feature or improvement
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants