Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

We're not seeing version v1.38 being available to golangci/golangci-lint-action #1813

Closed
3 of 4 tasks
magnetikonline opened this issue Mar 3, 2021 · 17 comments · Fixed by #1827
Closed
3 of 4 tasks
Labels
area: ci PR that update CI bug Something isn't working

Comments

@magnetikonline
Copy link
Contributor

magnetikonline commented Mar 3, 2021

  • Yes, I'm using a binary release within 2 latest major releases. Only such installations are supported.
  • Yes, I've searched similar issues on GitHub and didn't find any.
  • Yes, I've included all information below (version, config, etc).
  • Yes, I've tried with the standalone linter if available. (https://golangci-lint.run/usage/linters/)
GitHub workflow with the following:
 - name: Lint
        uses: golangci/golangci-lint-action@v2
        with:
          version: v1.38
Version of golangci-lint
$ golangci-lint --version
# golangci-lint has version 1.38.0 built from 507703b4 on 2021-03-03T13:53:01Z
Config file
$ cat .golangci.yml
# paste output here
Go environment
$ go version && go env
# paste output here
Verbose output of running
Error: Failed to run: Error: requested golangci-lint version 'v1.38' doesn't exist, Error: requested golangci-lint version 'v1.38' doesn't exist
    at Object.<anonymous> (/home/runner/work/_actions/golangci/golangci-lint-action/v2/dist/run/index.js:2351:19)
    at Generator.next (<anonymous>)
    at fulfilled (/home/runner/work/_actions/golangci/golangci-lint-action/v2/dist/run/index.js:2230:58)
    at processTicksAndRejections (internal/process/task_queues.js:93:5)
Error: requested golangci-lint version 'v1.38' doesn't exist
Code example or link to a public repository
// add your code here
@magnetikonline magnetikonline added the bug Something isn't working label Mar 3, 2021
@boring-cyborg
Copy link

boring-cyborg bot commented Mar 3, 2021

Hey, thank you for opening your first Issue ! 🙂 If you would like to contribute we have a guide for contributors.

@magnetikonline magnetikonline changed the title We're not seeing v1.38 being available to https://github.com/golangci/golangci-lint-action We're not seeing version v1.38 being available to golangci/golangci-lint-action Mar 3, 2021
@SVilgelm
Copy link
Member

SVilgelm commented Mar 3, 2021

@magnetikonline We are trying to automate the post release actions and the last run is failed. I want to wait one more day a response from @jirfag . If no response, then I will update the repo manually.

Here is PR: #1460
Action: https://github.com/golangci/golangci-lint/actions/workflows/post-release.yml

cc: @ldez

@SVilgelm SVilgelm added the area: ci PR that update CI label Mar 3, 2021
@magnetikonline
Copy link
Contributor Author

Nice one @SVilgelm - seems it failed building the contributors list.

@SVilgelm
Copy link
Member

SVilgelm commented Mar 3, 2021

yep, the bot's user should be added to the golangci/team

@SVilgelm
Copy link
Member

SVilgelm commented Mar 4, 2021

@jirfag @ernado please add the @golangci-releaser user to the team, we need it for the post-release automation

@ernado
Copy link
Member

ernado commented Mar 4, 2021

ACK, will do

@ernado
Copy link
Member

ernado commented Mar 4, 2021

What permissions we need to provide to @golangci-releaser?

@SVilgelm
Copy link
Member

SVilgelm commented Mar 4, 2021

@ernado I think write as other members

@ldez
Copy link
Member

ldez commented Mar 4, 2021

@SVilgelm
Copy link
Member

SVilgelm commented Mar 5, 2021

@ernado @jirfag It's a blocker now. Could you please add the @golangci-releaser user to the team https://github.com/orgs/golangci/teams/team/members ?

@magnetikonline
Copy link
Contributor Author

We're still broken? If there anyone else that can add https://github.com/golangci-releaser into the team so we can kick the build along again?

Thanks!

@ernado
Copy link
Member

ernado commented Mar 8, 2021

I've PM-ed @jirfag

@ldez
Copy link
Member

ldez commented Mar 9, 2021

I think it's time to create a PR, we will retry the automatic system with the next release if the rights problem is solved.

I created a PR: #1827

@ernado
Copy link
Member

ernado commented Mar 9, 2021

@golangci-releaser was added to org.

@ldez ldez mentioned this issue Mar 9, 2021
4 tasks
@ldez
Copy link
Member

ldez commented Mar 9, 2021

Thank you @ernado and @jirfag

We will test that with the next release 👍

@ldez ldez closed this as completed Mar 9, 2021
@SVilgelm
Copy link
Member

SVilgelm commented Mar 9, 2021

@ldez I re-run the failed action: https://github.com/golangci/golangci-lint/runs/2068816507?check_suite_focus=true
the PR was created successfully: #1828

so we can assume that it works

@magnetikonline
Copy link
Contributor Author

Thanks @SVilgelm and @ernado - we're back in action! 🎉

Appreciate all your help on this one 👍

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area: ci PR that update CI bug Something isn't working
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants