pkg/lint/lintersdb: report all unknown linters at once #1477
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hey, thank you for opening your first Pull Request ! |
|
|
|
Hey @invidian, thank you for contribution! Please fix linting warnings. |
Otherwise, if one configures multiple invalid linters, or jumps between the versions, it is annoying to get same error with different value N times. Signed-off-by: Mateusz Gozdek <mgozdekof@gmail.com>
invidian
force-pushed
the
linter-reporting
branch
from
4956599
to
4d276eb
Compare
Fixed, sorry about that. And it seems Mac OS tests failing are unrelated to the proposed change. |
iwankgb
approved these changes
Nov 1, 2020
|
Hey, @invidian — we just merged your PR to
By joining the team, you’ll be able to label issues, review pull requests, and merge approved pull requests. Thanks again! |
3 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Otherwise, if one configures multiple invalid linters, or jumps between
the versions, it is annoying to get same error with different value N
times.
Signed-off-by: Mateusz Gozdek mgozdekof@gmail.com