Skip to content

Commit

Permalink
pkg/lint/lintersdb: report all unknown linters at once
Browse files Browse the repository at this point in the history
Otherwise, if one configures multiple invalid linters, or jumps between
the versions, it is annoying to get same error with different value N
times.

Signed-off-by: Mateusz Gozdek <mgozdekof@gmail.com>
  • Loading branch information
invidian committed Oct 31, 2020
1 parent dc2d6b5 commit 4956599
Showing 1 changed file with 8 additions and 1 deletion.
9 changes: 8 additions & 1 deletion pkg/lint/lintersdb/validator.go
Expand Up @@ -20,12 +20,19 @@ func NewValidator(m *Manager) *Validator {
func (v Validator) validateLintersNames(cfg *config.Linters) error {
allNames := append([]string{}, cfg.Enable...)
allNames = append(allNames, cfg.Disable...)

unknownNames := []string{}

for _, name := range allNames {
if v.m.GetLinterConfigs(name) == nil {
return fmt.Errorf("no such linter %v, run 'golangci-lint linters' to see the list of supported linters", name)
unknownNames = append(unknownNames, name)
}
}

if len(unknownNames) > 0 {
return fmt.Errorf("unknown linters: '%v', run 'golangci-lint linters' to see the list of supported linters", strings.Join(unknownNames, ","))
}

return nil
}

Expand Down

0 comments on commit 4956599

Please sign in to comment.