docs: Add description of Homebrew's official formula #1421
Conversation
|
Hey, thank you for opening your first Pull Request ! |
|
|
| @@ -53,6 +53,13 @@ brew install golangci/tap/golangci-lint | |||
| brew upgrade golangci/tap/golangci-lint | |||
| ``` | |||
|
|
|||
| If you don't want to use tap, official formula also available. but it requires install Go compiler from Homebrew, so be careful. | |||
There was a problem hiding this comment.
This is valid change, indeed but could you:
- delete section that mentions the tap above (it isn't maintained anymore)
- do not mention obsolete tap in your change?
There was a problem hiding this comment.
It looks like the tap is still being maintained, is there any information anywhere that the tap is obsolete?
https://github.com/golangci/homebrew-tap/commits/master
There was a problem hiding this comment.
Huh, I guess we keep it for backward compatibility reason or because we missed the fact that tap is still being upgraded. Removing it from the docs sounds like a good idea to me anyway.
|
There are some conflicts, apparently. |
|
Hey, @rinsuki — we just merged your PR to
By joining the team, you’ll be able to label issues, review pull requests, and merge approved pull requests. Thanks again! |
golangci-lintformula looks available in Homebrew's official formula, so I added description of Homebrew's official formula.