Fix: goheader linter can throw nil pointer exception in case of a sou…

…rce file has not issues (#1209) * fix potential nil pointer exception Signed-off-by: denis-tingajkin <denis.tingajkin@xored.com> * add test to cover Signed-off-by: denis-tingajkin <denis.tingajkin@xored.com>
golangci · Jul 5, 2020 · dfa0013 · dfa0013
1 parent afa9be6
commit dfa0013
Show file tree

Hide file tree

Showing 4 changed files with 12 additions and 0 deletions.
diff --git a/pkg/golinters/goheader.go b/pkg/golinters/goheader.go
@@ -51,6 +51,9 @@ func NewGoHeader() *goanalysis.Linter {
 			var res []goanalysis.Issue
 			for _, file := range pass.Files {
 				i := a.Analyze(file)
+				if i == nil {
+					continue
+				}
 				issue := result.Issue{
 					Pos: token.Position{
 						Line:     i.Location().Line + 1,

diff --git a/test/linters_test.go b/test/linters_test.go
@@ -193,6 +193,9 @@ func extractRunContextFromComments(t *testing.T, sourcePath string) *runContext
 			skipMultilineComment(scanner)
 			continue
 		}
+		if strings.TrimSpace(line) == "" {
+			continue
+		}
 		if !strings.HasPrefix(line, "//") {
 			return rc
 		}

diff --git a/test/testdata/go-header.go → test/testdata/go-header_bad.go b/test/testdata/go-header.go → test/testdata/go-header_bad.go
@@ -1,4 +1,5 @@
 /*MY TITLE!*/ // ERROR "Expected:TITLE., Actual: TITLE!"
+
 //args: -Egoheader
 //config_path: testdata/configs/go-header.yml
 package testdata
diff --git a/test/testdata/go-header_good.go b/test/testdata/go-header_good.go
@@ -0,0 +1,5 @@
+/*MY TITLE.*/
+
+//args: -Egoheader
+//config_path: testdata/configs/go-header.yml
+package testdata