Assume single whitespace was intended when multiple leading whitespac…

…es are encountered
golangci · Dec 28, 2020 · db6956d · db6956d
1 parent 7c992af
commit db6956d
Show file tree

Hide file tree

Showing 2 changed files with 16 additions and 13 deletions.
diff --git a/pkg/golinters/nolintlint/nolintlint.go b/pkg/golinters/nolintlint/nolintlint.go
@@ -181,18 +181,21 @@ func (l Linter) Run(fset *token.FileSet, nodes ...ast.Node) ([]Issue, error) {
 
 					// check for, report and eliminate leading spaces so we can check for other issues
 					if len(leadingSpace) > 0 {
+						removeWhitespace := &result.Replacement{
+							Inline: &result.InlineFix{
+								StartCol:  pos.Column + 1,
+								Length:    len(leadingSpace),
+								NewString: "",
+							},
+						}
 						if (l.needs & NeedsMachineOnly) != 0 {
 							issue := NotMachine{BaseIssue: base}
-							issue.BaseIssue.replacement = &result.Replacement{
-								Inline: &result.InlineFix{
-									StartCol:  pos.Column - 1,
-									Length:    len(leadingSpace) + 2,
-									NewString: "//",
-								},
-							}
+							issue.BaseIssue.replacement = removeWhitespace
 							issues = append(issues, issue)
 						} else if len(leadingSpace) > 1 {
 							issue := ExtraLeadingSpace{BaseIssue: base}
+							issue.BaseIssue.replacement = removeWhitespace
+							issue.BaseIssue.replacement.Inline.NewString = " " // assume a single space was intended 
 							issues = append(issues, issue)
 						}
 					}

diff --git a/pkg/golinters/nolintlint/nolintlint_test.go b/pkg/golinters/nolintlint/nolintlint_test.go
@@ -102,9 +102,9 @@ func foo() {
 					"directive `// nolint` should be written without leading space as `//nolint` at testing.go:5:9",
 					&result.Replacement{
 						Inline: &result.InlineFix{
-							StartCol:  8,
-							Length:    3,
-							NewString: "//",
+							StartCol:  10,
+							Length:    1,
+							NewString: "",
 						},
 					},
 				},
@@ -124,9 +124,9 @@ func foo() {
 					"directive `//  nolint` should not have more than one leading space at testing.go:5:9",
 					&result.Replacement{
 						Inline: &result.InlineFix{
-							StartCol:  8,
-							Length:    4,
-							NewString: "//",
+							StartCol:  10,
+							Length:    2,
+							NewString: " ",
 						},
 					},
 				},