Skip to content

Commit

Permalink
exhaustive: drop deprecated/unused settings (#2482)
Browse files Browse the repository at this point in the history
  • Loading branch information
butuzov committed Jan 14, 2022
1 parent 9dacd61 commit cf053b2
Show file tree
Hide file tree
Showing 2 changed files with 1 addition and 7 deletions.
5 changes: 1 addition & 4 deletions pkg/config/linters_settings.go
Original file line number Diff line number Diff line change
Expand Up @@ -21,7 +21,7 @@ var defaultLintersSettings = LintersSettings{
CheckGenerated: false,
DefaultSignifiesExhaustive: false,
IgnoreEnumMembers: "",
CheckingStrategy: "value",
PackageScopeOnly: false,
},
Forbidigo: ForbidigoSettings{
ExcludeGodocExamples: true,
Expand Down Expand Up @@ -223,9 +223,6 @@ type ExhaustiveSettings struct {
DefaultSignifiesExhaustive bool `mapstructure:"default-signifies-exhaustive"`
IgnoreEnumMembers string `mapstructure:"ignore-enum-members"`
PackageScopeOnly bool `mapstructure:"package-scope-only"`

IgnorePattern string `mapstructure:"ignore-pattern"` // Deprecated: this setting has no effect; see IgnoreEnumMembers instead.
CheckingStrategy string `mapstructure:"checking-strategy"` // Deprecated.
}

type ExhaustiveStructSettings struct {
Expand Down
3 changes: 0 additions & 3 deletions pkg/golinters/exhaustive.go
Original file line number Diff line number Diff line change
Expand Up @@ -19,9 +19,6 @@ func NewExhaustive(settings *config.ExhaustiveSettings) *goanalysis.Linter {
exhaustive.DefaultSignifiesExhaustiveFlag: settings.DefaultSignifiesExhaustive,
exhaustive.IgnoreEnumMembersFlag: settings.IgnoreEnumMembers,
exhaustive.PackageScopeOnlyFlag: settings.PackageScopeOnly,

exhaustive.IgnorePatternFlag: settings.IgnorePattern,
exhaustive.CheckingStrategyFlag: settings.CheckingStrategy,
},
}
}
Expand Down

0 comments on commit cf053b2

Please sign in to comment.