chore: remove TypecheckMode

golangci · Mar 20, 2021 · 8595e54 · 8595e54
1 parent 5189701
commit 8595e54
Show file tree

Hide file tree

Showing 4 changed files with 3 additions and 20 deletions.
diff --git a/pkg/golinters/goanalysis/linter.go b/pkg/golinters/goanalysis/linter.go
@@ -49,7 +49,6 @@ type Linter struct {
 	contextSetter           func(*linter.Context)
 	loadMode                LoadMode
 	needUseOriginalPackages bool
-	isTypecheckModeOn       bool
 }
 
 func NewLinter(name, desc string, analyzers []*analysis.Analyzer, cfg map[string]map[string]interface{}) *Linter {
@@ -68,10 +67,6 @@ func (lnt *Linter) UseOriginalPackages() {
 	lnt.needUseOriginalPackages = true
 }
 
-func (lnt *Linter) SetTypecheckMode() {
-	lnt.isTypecheckModeOn = true
-}
-
 func (lnt *Linter) LoadMode() LoadMode {
 	return lnt.loadMode
 }
@@ -181,10 +176,6 @@ func (lnt *Linter) useOriginalPackages() bool {
 	return lnt.needUseOriginalPackages
 }
 
-func (lnt *Linter) isTypecheckMode() bool {
-	return lnt.isTypecheckModeOn
-}
-
 func (lnt *Linter) reportIssues(lintCtx *linter.Context) []Issue {
 	if lnt.issuesReporter != nil {
 		return lnt.issuesReporter(lintCtx)

diff --git a/pkg/golinters/goanalysis/metalinter.go b/pkg/golinters/goanalysis/metalinter.go
@@ -39,15 +39,6 @@ func (ml MetaLinter) Desc() string {
 	return ""
 }
 
-func (ml MetaLinter) isTypecheckMode() bool {
-	for _, l := range ml.linters {
-		if l.isTypecheckMode() {
-			return true
-		}
-	}
-	return false
-}
-
 func (ml MetaLinter) getLoadMode() LoadMode {
 	loadMode := LoadModeNone
 	for _, l := range ml.linters {

diff --git a/pkg/golinters/goanalysis/runners.go b/pkg/golinters/goanalysis/runners.go
@@ -23,7 +23,6 @@ type runAnalyzersConfig interface {
 	getLinterNameForDiagnostic(*Diagnostic) string
 	getAnalyzers() []*analysis.Analyzer
 	useOriginalPackages() bool
-	isTypecheckMode() bool
 	reportIssues(*linter.Context) []Issue
 	getLoadMode() LoadMode
 }

diff --git a/pkg/golinters/typecheck.go b/pkg/golinters/typecheck.go
@@ -8,19 +8,21 @@ import (
 
 func NewTypecheck() *goanalysis.Linter {
 	const linterName = "typecheck"
+
 	analyzer := &analysis.Analyzer{
 		Name: linterName,
 		Doc:  goanalysis.TheOnlyanalyzerDoc,
 		Run: func(pass *analysis.Pass) (interface{}, error) {
 			return nil, nil
 		},
 	}
+
 	linter := goanalysis.NewLinter(
 		linterName,
 		"Like the front-end of a Go compiler, parses and type-checks Go code",
 		[]*analysis.Analyzer{analyzer},
 		nil,
 	).WithLoadMode(goanalysis.LoadModeTypesInfo)
-	linter.SetTypecheckMode()
+
 	return linter
 }