Skip to content

Commit

Permalink
revive: fix default values
Browse files Browse the repository at this point in the history
  • Loading branch information
ldez committed Feb 22, 2022
1 parent 0e7233e commit 3b05fe4
Show file tree
Hide file tree
Showing 4 changed files with 5 additions and 9 deletions.
1 change: 0 additions & 1 deletion go.mod
Expand Up @@ -55,7 +55,6 @@ require (
github.com/matoous/godox v0.0.0-20210227103229-6504466cf951 // v1.0
github.com/mattn/go-colorable v0.1.12
github.com/mbilski/exhaustivestruct v1.2.0
github.com/mgechev/dots v0.0.0-20210922191527-e955255bf517
github.com/mgechev/revive v1.1.4
github.com/mitchellh/go-homedir v1.1.0
github.com/mitchellh/go-ps v1.0.0
Expand Down
1 change: 0 additions & 1 deletion go.sum

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

4 changes: 4 additions & 0 deletions pkg/config/linters_settings.go
Expand Up @@ -79,6 +79,10 @@ var defaultLintersSettings = LintersSettings{
Ignore: "",
Qualified: false,
},
Revive: ReviveSettings{
Confidence: 0.8,
Severity: "warning",
},
Testpackage: TestpackageSettings{
SkipRegexp: `(export|internal)_test\.go`,
},
Expand Down
8 changes: 1 addition & 7 deletions pkg/golinters/revive.go
Expand Up @@ -9,7 +9,6 @@ import (
"reflect"

"github.com/BurntSushi/toml"
"github.com/mgechev/dots"
reviveConfig "github.com/mgechev/revive/config"
"github.com/mgechev/revive/lint"
"github.com/mgechev/revive/rule"
Expand Down Expand Up @@ -50,10 +49,10 @@ func NewRevive(cfg *config.ReviveSettings) *goanalysis.Linter {
).WithContextSetter(func(lintCtx *linter.Context) {
analyzer.Run = func(pass *analysis.Pass) (interface{}, error) {
var files []string

for _, file := range pass.Files {
files = append(files, pass.Fset.PositionFor(file.Pos(), false).Filename)
}
packages := [][]string{files}

conf, err := getReviveConfig(cfg)
if err != nil {
Expand All @@ -72,11 +71,6 @@ func NewRevive(cfg *config.ReviveSettings) *goanalysis.Linter {
return nil, err
}

packages, err := dots.ResolvePackages(files, []string{})
if err != nil {
return nil, err
}

failures, err := revive.Lint(packages, lintingRules, *conf)
if err != nil {
return nil, err
Expand Down

0 comments on commit 3b05fe4

Please sign in to comment.