Update "version" config in README example #167
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
golangci#98 was closed by golangci#101, but the README still says that only a major-minor version is accepted. It also says that this field is required, but `action.yml` says otherwise. Copy the description from `action.yml` into the README for consistency.
SVilgelm
approved these changes
Feb 23, 2021
This was referenced Mar 8, 2021
kolyshkin
added a commit
to kolyshkin/libseccomp-golang
that referenced
this pull request
May 6, 2022
Bumps: * Update actions/checkout, actions/setup-go, golangci/golangci-lint-action from v2 to v3. * Bump golangci-lint to v1.45. Cleanups: * Remove "stable" parameter for setup-go (not needed since v3, see [1]). * Remove the obsoleted comment for golangci-lint (no longer true, see [2]). [1] https://github.com/actions/setup-go/releases/tag/v3.0.0 [2] golangci/golangci-lint-action#167 Signed-off-by: Kir Kolyshkin <kolyshkin@gmail.com>
drakenclimber
pushed a commit
to seccomp/libseccomp-golang
that referenced
this pull request
May 10, 2022
Bumps: * Update actions/checkout, actions/setup-go, golangci/golangci-lint-action from v2 to v3. * Bump golangci-lint to v1.45. Cleanups: * Remove "stable" parameter for setup-go (not needed since v3, see [1]). * Remove the obsoleted comment for golangci-lint (no longer true, see [2]). [1] https://github.com/actions/setup-go/releases/tag/v3.0.0 [2] golangci/golangci-lint-action#167 Signed-off-by: Kir Kolyshkin <kolyshkin@gmail.com> Acked-by: Paul Moore <paul@paul-moore.com> Signed-off-by: Tom Hromatka <tom.hromatka@oracle.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
#98 was closed by #101, but the README still says that only a major-minor version is accepted. It also says that this field is required, but
action.ymlsays otherwise. Copy the description fromaction.ymlinto the README for consistency.