Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Allow disabeling go mod cache #153

Closed
smyrman opened this issue Jan 27, 2021 · 2 comments · Fixed by #154
Closed

Allow disabeling go mod cache #153

smyrman opened this issue Jan 27, 2021 · 2 comments · Fixed by #154
Labels
area: cache

Comments

@smyrman
Copy link
Contributor

smyrman commented Jan 27, 2021

There may be good reason for not letting this task restore, cache or download modules. E.g. in our case, we have private dependencies that require setting the GOPRIVATE environment variable in order to resolve all dependencies. Besides, as we already save and restore the module cache for tests, why not reuse it for lint.

Therefore, having a way to turn off module cache, in the same way you can configure to not install go, would be very handy.
@Jimeux
Copy link

Jimeux commented Jan 28, 2021

I think this could also be a way of resolving #135. People who generate their own cache could just disable the cache inside the action.

@smyrman
Copy link
Contributor Author

smyrman commented Jan 28, 2021

If solving this, probably makes sense to allow disabling build cache as well.

@smyrman smyrman mentioned this issue Jan 28, 2021
Merged
mtardy added a commit to cilium/tetragon that referenced this issue Aug 22, 2023
@mtardy
golangci-lint: increase timeout and enable caching
14c67be 
Caching was disabled for stuff that might not apply anymore:
golangci/golangci-lint-action#153
We were timing out on the analysis so this might help.

Signed-off-by: Mahe Tardy <mahe.tardy@gmail.com>
@mtardy mtardy mentioned this issue Aug 22, 2023
Merged
kkourt pushed a commit to cilium/tetragon that referenced this issue Aug 22, 2023
@mtardy @kkourt
golangci-lint: increase timeout and enable caching
dd951f4 
Caching was disabled for stuff that might not apply anymore:
golangci/golangci-lint-action#153
We were timing out on the analysis so this might help.

Signed-off-by: Mahe Tardy <mahe.tardy@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
area: cache
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Add options to skip caching of folders. clarify/golangci-lint-action
3 participants
@smyrman @Jimeux @ldez