Skip to content

Commit

Permalink
golangci-lint: increase timeout and enable caching
Browse files Browse the repository at this point in the history
Caching was disabled for stuff that might not apply anymore:
golangci/golangci-lint-action#153
We were timing out on the analysis so this might help.

Signed-off-by: Mahe Tardy <mahe.tardy@gmail.com>
  • Loading branch information
mtardy committed Aug 22, 2023
1 parent ec27bbc commit 14c67be
Show file tree
Hide file tree
Showing 2 changed files with 7 additions and 2 deletions.
7 changes: 6 additions & 1 deletion .github/workflows/static-checks.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -12,6 +12,10 @@ on:
- 'docs/**'
- '**.md'

permissions:
# For golangci/golangci-lint to have read access to pull request for `only-new-issues` option.
contents: read

jobs:
golangci-lint:
runs-on: ubuntu-latest
Expand All @@ -24,14 +28,15 @@ jobs:
with:
# renovate: datasource=golang-version depName=go
go-version: '1.20.7'
# using golangci-lint cache instead
cache: false

- name: Run golangci-lint
uses: golangci/golangci-lint-action@639cd343e1d3b897ff35927a75193d57cfcba299 # v3.6.0
with:
# renovate: datasource=docker depName=docker.io/golangci/golangci-lint
version: v1.53.3
args: --config=.golangci.yml --verbose
skip-cache: true

format:
runs-on: ubuntu-latest
Expand Down
2 changes: 1 addition & 1 deletion .golangci.yml
Original file line number Diff line number Diff line change
@@ -1,7 +1,7 @@
# See https://golangci-lint.run/usage/configuration/ for available options.
# Also https://github.com/cilium/cilium/blob/master/.golangci.yaml as a reference.
run:
timeout: 5m
timeout: 10m

output:
format: tab
Expand Down

0 comments on commit 14c67be

Please sign in to comment.