Skip to content

Commit

Permalink
gopls/internal/test/integration/misc: disable staticcheck test
Browse files Browse the repository at this point in the history
Until staticcheck supports range-over-func, gopls won't attempt
to run it on packages that use range-over-func, which is about to
be nearly all packages. Our existing tests will not work.
So, disable them for now.

Updates dominikh/go-tools#1494
Updates golang/go#67262

Change-Id: Ia498b6122cbb7d3797d5d552acbbf0b3dc736eb9
Reviewed-on: https://go-review.googlesource.com/c/tools/+/584395
LUCI-TryBot-Result: Go LUCI <golang-scoped@luci-project-accounts.iam.gserviceaccount.com>
Auto-Submit: Alan Donovan <adonovan@google.com>
Reviewed-by: Robert Findley <rfindley@google.com>
  • Loading branch information
adonovan authored and gopherbot committed May 8, 2024
1 parent f38ac9b commit 8f9d159
Showing 1 changed file with 7 additions and 0 deletions.
7 changes: 7 additions & 0 deletions gopls/internal/test/integration/misc/staticcheck_test.go
Expand Up @@ -16,6 +16,13 @@ import (
func TestStaticcheckGenerics(t *testing.T) {
testenv.NeedsGo1Point(t, 20) // staticcheck requires go1.20+

// CL 583778 causes buildir not to run on packages that use
// range-over-func, since it might otherwise crash. But nearly
// all packages will soon meet this description, so the
// analyzers in this test will not run, and the test will fail.
// TODO(adonovan): reenable once dominikh/go-tools#1494 is fixed.
t.Skip("disabled until buildir supports range-over-func (dominikh/go-tools#1494)")

// TODO(golang/go#65249): re-enable and fix this test once we
// update go.mod to go1.23 so that gotypesalias=1 becomes the default.
if aliases.Enabled() {
Expand Down

0 comments on commit 8f9d159

Please sign in to comment.