Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

all: fix reflect.Value.Interface races #913

Merged
merged 1 commit into from Aug 5, 2019
Merged

all: fix reflect.Value.Interface races #913

merged 1 commit into from Aug 5, 2019

Commits on Jul 27, 2019

  1. all: fix reflect.Value.Interface races 

    The reflect.Value.Interface method shallow copies the underlying value,
which may copy mutexes and atomically-accessed fields.
Some usages of the Interface method is only to check if the interface value
implements an interface. In which case the shallow copy was unnecessary.
Change those usages to use the reflect.Value.Implements method instead.

Fixes #838
    @dsnet
    dsnet committed Jul 27, 2019
    Configuration menu
    Copy the full SHA
    4f0f324 View commit details
    Browse the repository at this point in the history