Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

jsonpb: bring back old behaviour of handling nulls and JSONPBUnmarshaler #1300

Merged
merged 2 commits into from Mar 24, 2021
Merged

jsonpb: bring back old behaviour of handling nulls and JSONPBUnmarshaler #1300

merged 2 commits into from Mar 24, 2021

Commits on Mar 22, 2021

  1. jsonpb: bring back old behaviour of handling nulls and JSONPBUnmarshaler 

    Change how jsonpb.Unmarshal handles nested JSONPBMarshaler fields a null json values.

When json null is encountered for a field which implements JSONPBUnmarshaler, jsonpb will now calli unmarshal method from the field, instead of just assigning nil to this field.
    @krzysztofdrys
    krzysztofdrys committed Mar 22, 2021
    Copy the full SHA
    2ab1774 View commit details
    Browse the repository at this point in the history

Commits on Mar 24, 2021

  1. code review changes

    @krzysztofdrys
    krzysztofdrys committed Mar 24, 2021
    Copy the full SHA
    80c245a View commit details
    Browse the repository at this point in the history