Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

proto: convert integer to rune before converting to string #1210

Merged
merged 1 commit into from Sep 24, 2020
Merged

proto: convert integer to rune before converting to string #1210

merged 1 commit into from Sep 24, 2020

Commits on Sep 24, 2020

  1. proto: convert integer to rune before converting to string 

    Go 1.15 introduced a new `go vet` warning
(https://golang.org/doc/go1.15#vet) for conversions of the form
`string(x)` where `x` is an integer type other than `rune` or `byte`.
This warning is enabled by default when running `go test`. As a
consequence, running `go test github.com/golang/protobuf/proto`
results in a build failure prior to this commit.
    @saser
    saser committed Sep 24, 2020
    Copy the full SHA
    cecedc1 View commit details
    Browse the repository at this point in the history