Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

proto: make InternalMessageInfo functional #1129

Merged
merged 1 commit into from May 14, 2020
Merged

proto: make InternalMessageInfo functional #1129

merged 1 commit into from May 14, 2020

Commits on May 14, 2020

  1. proto: make InternalMessageInfo functional

    The InternalMessageInfo type only exists to implement the
    XXX methods on generated messages where those methods were
    only ever intended to be called by this module itself.
    
    Since v1.4.0, this module no longer relies on the XXX methods,
    so the InternalMessageInfo and its implementation is supposed
    to be dead code. Unfortunately, there are external usages that
    violate our compatibility agreement and either directly call
    the XXX methods or indirectly call it because some library
    type-asserts to the existence of these methods.
    
    This change adds minimal support for InternalMessageInfo by
    just calling out directly to the v2 implementation.
    dsnet committed May 14, 2020
    Configuration menu
    Copy the full SHA
    4b3fa25 View commit details
    Browse the repository at this point in the history