Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow set audience on google OAuth flow #558

Open
wants to merge 2 commits into
base: master
Choose a base branch
from
Open

Conversation

DKbyo
Copy link

@DKbyo DKbyo commented Mar 14, 2022

Fixes #557

If audience is not set, it will use Token URL as expected

@google-cla
Copy link

google-cla bot commented Mar 14, 2022

Thanks for your pull request! It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

For more information, open the CLA check for this pull request.

@gopherbot
Copy link
Contributor

This PR (HEAD: 7b14cbc) has been imported to Gerrit for code review.

Please visit https://go-review.googlesource.com/c/oauth2/+/392256 to see it.

Tip: You can toggle comments from me using the comments slash command (e.g. /comments off)
See the Wiki page for more info

@gopherbot
Copy link
Contributor

Message from Gopher Robot:

Patch Set 1:

Congratulations on opening your first change. Thank you for your contribution!

Next steps:
A maintainer will review your change and provide feedback. See
https://go.dev/doc/contribute#review for more info and tips to get your
patch through code review.

Most changes in the Go project go through a few rounds of revision. This can be
surprising to people new to the project. The careful, iterative review process
is our way of helping mentor contributors and ensuring that their contributions
have a lasting impact.


Please don’t reply on this GitHub thread. Visit golang.org/cl/392256.
After addressing review feedback, remember to publish your drafts!

@DKbyo
Copy link
Author

DKbyo commented Mar 14, 2022

This will be fixed with googleapis/google-api-go-client#1476

@DKbyo DKbyo changed the title Allow set audience from service account file Allow set audience on google OAuth flow Mar 17, 2022
@gopherbot
Copy link
Contributor

This PR (HEAD: ead5e9d) has been imported to Gerrit for code review.

Please visit https://go-review.googlesource.com/c/oauth2/+/392256 to see it.

Tip: You can toggle comments from me using the comments slash command (e.g. /comments off)
See the Wiki page for more info

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Allow set audience for Google Service Accounts
2 participants