Skip to content
This repository has been archived by the owner on Jun 27, 2023. It is now read-only.

Support type-safe return values #630

Closed
wants to merge 2 commits into from
Closed

Support type-safe return values #630

wants to merge 2 commits into from

Conversation

tra4less
Copy link
Contributor

No description provided.

@tra4less tra4less requested a review from codyoss as a code owner March 11, 2022 08:12
@tra4less
Copy link
Contributor Author

tra4less commented Mar 11, 2022

#622 #427 #634 #657

@danielvladco
Copy link

Hi, is there any progress on this PR?

@falsaffa
Copy link

Hey, any updates here?

cc @codyoss

@trim21
Copy link

trim21 commented May 11, 2022

any progress on this?

@falsaffa
Copy link

falsaffa commented Jun 5, 2022

Hey @codyoss , is there anything @n0trace/we/anyone can do to help get this PR reviewed and approved?

@tra4less
Copy link
Contributor Author

The implementation changed, by adding a flag. @codyoss @trim21
reference #622

@trim21
Copy link

trim21 commented Jun 11, 2022

add new flag in readme?

@falsaffa
Copy link

falsaffa commented Jul 7, 2022

@codyoss @n0trace any progress with the PR?

@tra4less
Copy link
Contributor Author

cc @codyoss

@rekby
Copy link

rekby commented Sep 6, 2022

@codyoss Is any ETA for review of the PR?

@jhalterman
Copy link

Would love to see this reviewed. Putting the feature behind a new flag seems like a good way to introduce it.

@trim21
Copy link

trim21 commented Jan 12, 2023

/ping

@alvarotuso
Copy link

Bump. This would be very useful.

@trim21
Copy link

trim21 commented May 7, 2023

cc @codyoss

@skynet2
Copy link

skynet2 commented Jun 23, 2023

hi @n0trace , this also requires one additional fix for optional vars.

Example interface:

import (
	"context"
	"fmt"

	"github.com/aws/aws-sdk-go-v2/aws"
	"github.com/aws/aws-sdk-go-v2/config"
	"github.com/aws/aws-sdk-go-v2/service/s3"
)

type s3Client interface {
	HeadBucket(ctx context.Context, input *s3.HeadBucketInput, opts ...func(*s3.Options)) (*s3.HeadBucketOutput, error)
}

will generate incorrect mock Return func:
image
fix is skynet2@ca75ee6
image

Thanks

@trim21
Copy link

trim21 commented Jun 25, 2023

@codyoss can anyone review this PR?

@tra4less
Copy link
Contributor Author

@codyoss can anyone review this PR?

Good news: Codyoss' github is highly active.
Bad news: Not active in this repository.

@tra4less tra4less closed this by deleting the head repository Jan 8, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

8 participants