This repository has been archived by the owner on Jun 27, 2023. It is now read-only.
allow for overriding source package #529
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@choo-stripe Would you please open a feature request for this PR. We like to have discussion before implementing any features. |
|
Done: #531 |
|
Closing in favor of #547 |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Greetings!
We call
mockgenfrom bazel, which lives in a hermetic environment and doesn't have access to go modules or GOPATH. However, we shouldn't really need to magically find the name of the go package.This PR adds a flag to override the source package - so that if the mock file needs to import from the original file, it'll use the provided package.
I looked at writing tests. I didn't put this in
parsePackageImportbecause that function is called in multiple places, including to determine the destination path. We don't want to override the destination path. I thought about creating a new function,getPackageNameor something, but it didn't seem worthwhile.