Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

database/sql: prevent ErrBadConn from driver.Open() #35191

Closed
wants to merge 2 commits into from
Closed

database/sql: prevent ErrBadConn from driver.Open() #35191

wants to merge 2 commits into from

Commits on Oct 26, 2019

  1. prevent ErrBadConn from driver.Open() 

    because it seems this error is only meant to be internal, and if `ErrBadConn` is returned from here it can also be returned from the public api

See some confusion about this here: go-sql-driver/mysql#1020

And a fix in the postgres driver here: lib/pq@04c77ed
    @tjenkinson
    tjenkinson committed Oct 26, 2019
    Configuration menu
    Copy the full SHA
    590508a View commit details
    Browse the repository at this point in the history

  2. fix case

    @tjenkinson
    tjenkinson committed Oct 26, 2019
    Configuration menu
    Copy the full SHA
    cfda5c7 View commit details
    Browse the repository at this point in the history