You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
Change https://go.dev/cl/584395 mentions this issue: gopls/internal/test/integration/misc: disable staticcheck test
seankhliao
changed the title
gopls: reenable tests suppressed due to lack of build{ssa,ir} support for range-over-func or gotypesalias=1
x/tools/gopls: reenable tests suppressed due to lack of build{ssa,ir} support for range-over-func or gotypesalias=1
May 8, 2024
gopherbot
added
the
Tools
This label describes issues relating to any tools in the x/tools repository.
label
May 8, 2024
gopherbot
pushed a commit
to golang/tools
that referenced
this issue
May 8, 2024
Until staticcheck supports range-over-func, gopls won't attempt
to run it on packages that use range-over-func, which is about to
be nearly all packages. Our existing tests will not work.
So, disable them for now.
Updates dominikh/go-tools#1494
Updates golang/go#67262
Change-Id: Ia498b6122cbb7d3797d5d552acbbf0b3dc736eb9
Reviewed-on: https://go-review.googlesource.com/c/tools/+/584395
LUCI-TryBot-Result: Go LUCI <golang-scoped@luci-project-accounts.iam.gserviceaccount.com>
Auto-Submit: Alan Donovan <adonovan@google.com>
Reviewed-by: Robert Findley <rfindley@google.com>
I missed a test in CL 584395.
Updates golang/go#67262
Change-Id: I9edbaf46cd148631925d7d70d64cfff4eb7ff660
Reviewed-on: https://go-review.googlesource.com/c/tools/+/584298
Reviewed-by: Tim King <taking@google.com>
LUCI-TryBot-Result: Go LUCI <golang-scoped@luci-project-accounts.iam.gserviceaccount.com>
Auto-Submit: Alan Donovan <adonovan@google.com>
A number of gopls tests have been skipped. We shouldn't forget to reenable them when the upstream issues are fixed.
Pending CL adding SSA support for range-over-func:
Upstream issues:
The text was updated successfully, but these errors were encountered: