Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

apidiff: ignore internal packages #32

Closed
wants to merge 1 commit into from
Closed

apidiff: ignore internal packages #32

wants to merge 1 commit into from

Conversation

gh73962
Copy link
Contributor

@gh73962 gh73962 commented May 16, 2022 •
edited

A feature is added to apidiff that allows users to ignore internal package comparisons.

Fixes golang/go#52864.

@gopherbot
Copy link
Contributor

This PR (HEAD: 3b7c810) has been imported to Gerrit for code review.

Please visit https://go-review.googlesource.com/c/exp/+/406534 to see it.

Tip: You can toggle comments from me using the comments slash command (e.g. /comments off)
See the Wiki page for more info

@gopherbot
Copy link
Contributor

Message from hui Hui:

Patch Set 1:

(1 comment)

Please don’t reply on this GitHub thread. Visit golang.org/cl/406534.
After addressing review feedback, remember to publish your drafts!

@gopherbot
Copy link
Contributor

Message from hui Hui:

Patch Set 1:

(1 comment)

Please don’t reply on this GitHub thread. Visit golang.org/cl/406534.
After addressing review feedback, remember to publish your drafts!

@gopherbot
Copy link
Contributor

Message from Jonathan Amsterdam:

Patch Set 1:

(5 comments)

Please don’t reply on this GitHub thread. Visit golang.org/cl/406534.
After addressing review feedback, remember to publish your drafts!

@gopherbot
Copy link
Contributor

Message from Jonathan Amsterdam:

Patch Set 1:

(8 comments)

Please don’t reply on this GitHub thread. Visit golang.org/cl/406534.
After addressing review feedback, remember to publish your drafts!

@gopherbot
Copy link
Contributor

Message from hui Hui:

Patch Set 1:

(2 comments)

Please don’t reply on this GitHub thread. Visit golang.org/cl/406534.
After addressing review feedback, remember to publish your drafts!

@gh73962 gh73962 changed the title apidiff: ignore internal pack apidiff: ignore internal packages May 16, 2022
@gopherbot
Copy link
Contributor

This PR (HEAD: 367ebca) has been imported to Gerrit for code review.

Please visit https://go-review.googlesource.com/c/exp/+/406534 to see it.

Tip: You can toggle comments from me using the comments slash command (e.g. /comments off)
See the Wiki page for more info

@gopherbot
Copy link
Contributor

Message from Gopher Robot:

Patch Set 3:

Congratulations on opening your first change. Thank you for your contribution!

Next steps:
A maintainer will review your change and provide feedback. See
https://go.dev/doc/contribute#review for more info and tips to get your
patch through code review.

Most changes in the Go project go through a few rounds of revision. This can be
surprising to people new to the project. The careful, iterative review process
is our way of helping mentor contributors and ensuring that their contributions
have a lasting impact.

Please don’t reply on this GitHub thread. Visit golang.org/cl/406534.
After addressing review feedback, remember to publish your drafts!

@gopherbot
Copy link
Contributor

This PR (HEAD: e75bf43) has been imported to Gerrit for code review.

Please visit https://go-review.googlesource.com/c/exp/+/406534 to see it.

Tip: You can toggle comments from me using the comments slash command (e.g. /comments off)
See the Wiki page for more info

@gopherbot
Copy link
Contributor

This PR (HEAD: eb63de3) has been imported to Gerrit for code review.

Please visit https://go-review.googlesource.com/c/exp/+/406534 to see it.

Tip: You can toggle comments from me using the comments slash command (e.g. /comments off)
See the Wiki page for more info

@gh73962
apidiff: ignore internal packages
9b59beb 
The feature is added to apidiff which allows users to ignore internal package comparisons.

Fixes golang/go#52864.
@gopherbot
Copy link
Contributor

This PR (HEAD: 9b59beb) has been imported to Gerrit for code review.

Please visit https://go-review.googlesource.com/c/exp/+/406534 to see it.

Tip: You can toggle comments from me using the comments slash command (e.g. /comments off)
See the Wiki page for more info

@gopherbot
Copy link
Contributor

Message from hui Hui:

Patch Set 8:

(4 comments)

Please don’t reply on this GitHub thread. Visit golang.org/cl/406534.
After addressing review feedback, remember to publish your drafts!

gopherbot pushed a commit that referenced this pull request May 16, 2022
@gh73962 @jba
apidiff: ignore internal packages
24438e5 
A feature is added to apidiff that allows users to ignore internal package comparisons.

Fixes golang/go#52864.

Change-Id: Ic390e198ef81901a9aed4212bc6f49e73ab78336
GitHub-Last-Rev: 9b59beb
GitHub-Pull-Request: #32
Reviewed-on: https://go-review.googlesource.com/c/exp/+/406534
Reviewed-by: Jonathan Amsterdam <jba@google.com>
Reviewed-by: Jamal Carvalho <jamal@golang.org>
@gopherbot
Copy link
Contributor

This PR is being closed because golang.org/cl/406534 has been merged.

@gopherbot gopherbot closed this May 16, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
2 participants
@gh73962 @gopherbot