Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix Clickhouse driver to work correctly with v2 #950

Open
wants to merge 7 commits into
base: master
Choose a base branch
from

Conversation

jhzn
Copy link

@jhzn jhzn commented Jun 28, 2023

Updated this PR: #723

I'm not the original author. I've only updated his/her code with the latest master in hope of getting it merged.

Credit goes to: @lo00l

@obalunenko
Copy link

@jhzn please check why tests are broken for go 1.20

@jhzn
Copy link
Author

jhzn commented Aug 22, 2023

@jhzn please check why tests are broken for go 1.20

The failing tests are for yugabytedb, my change shouldn't touch that. I think the tests are a bit flaky, at least when I've run them locally. I can't rerun the tests on Github to confirm this.

@coveralls
Copy link

coveralls commented Jan 11, 2024

Coverage Status

coverage: 56.318% (-0.02%) from 56.335%
when pulling 87481e1 on jhzn:only_go_change
into f100226 on golang-migrate:master.

@jhzn
Copy link
Author

jhzn commented Jan 11, 2024

@jhzn please check why tests are broken for go 1.20

Working now 👍

@obalunenko
Copy link

obalunenko commented Jan 11, 2024

@dhui could you please take a look on this PR, when you have a chance? 🙏

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants