Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

clickhouse: add to README.md and examples database creation #875

Merged

Conversation

volum-nova
Copy link
Contributor

As clickhouse migrator doesnt't provide database creation, I can offer to note it in README.md and provide an example, how database can be created inside the migration without specifying database through connection string.

@coveralls
Copy link

Coverage Status

Coverage: 57.982% (+0.03%) from 57.953% when pulling 64755d0 on no-name16:clickhouse_create_database_migrations into dc26c41 on golang-migrate:master.

@coveralls
Copy link

coveralls commented Jan 24, 2023

Coverage Status

coverage: 59.085%. first build
when pulling ab24e76 on no-name16:clickhouse_create_database_migrations
into 691f687 on golang-migrate:master.

Copy link
Member

@dhui dhui left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@no-name16 Thanks for the PR and sorry for the long turnaround time. Life has been busy...

database/clickhouse/README.md Outdated Show resolved Hide resolved
@volum-nova volum-nova requested a review from dhui March 19, 2023 07:47
Copy link
Member

@dhui dhui left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@no-name16 sorry for the delay! Finally got around to merging this

@dhui dhui merged commit 9c551d4 into golang-migrate:master Dec 20, 2023
8 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants