Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upgrading Spanner version #809

Merged
merged 3 commits into from Mar 15, 2023
Merged

Upgrading Spanner version #809

merged 3 commits into from Mar 15, 2023

Conversation

jcuanmhoney
Copy link
Contributor

My team and I forked the repo and upgraded the Spanner libraries for our own purposes, so making this PR to help out.

Upgrading Spanner to version 1.38.0 as dictated in the docs here: https://pkg.go.dev/cloud.google.com/go/spanner

@jcuanmhoney jcuanmhoney marked this pull request as draft September 15, 2022 16:15
@jcuanmhoney jcuanmhoney marked this pull request as ready for review September 15, 2022 16:26
@coveralls
Copy link

coveralls commented Sep 15, 2022

Coverage Status

Coverage: 57.953%. Remained the same when pulling 4831e0e on jcuanmhoney:master into 952f3f0 on golang-migrate:master.

@dhui
Copy link
Member

dhui commented Mar 15, 2023

@jcuanmhoney Thanks for the PR and sorry about the delay in reviewing it. Life has been busy...

There were merge conflicts and there's a newer spanner version so I've pushed updates/fix to this PR accordingly

@dhui dhui merged commit 1d693e8 into golang-migrate:master Mar 15, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants