Add DuckDB support to migrate #1077
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Originally written in https://github.com/kubecost/golang-migrate-duckdb/tree/mmd/make-importable Signed-off-by: Michael Dresser <michaelmdresser@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This code was originally written here https://github.com/kubecost/golang-migrate-duckdb/tree/mmd/make-importable and has been moved to my fork for upstreaming. I focused on duplicating the sqlite3 implementation because DuckDB is behaviorally similar to SQLite. This code has been used in a private project successfully for a little while now.
DuckDB unfortunately has a CGO requirement like sqlite. I was not sure how to run the test suite using the Makefile when there is a CGO dependency present, so I just used a manual
go test -v ./database/duckdb/...to see if the unit tests succeeded. Please let me know if there is a way I can run the full test suite locally so as to not waste CI time.