Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

use sqlite3 driver without cgo #1065

Closed

Conversation

alonsobm
Copy link

@alonsobm alonsobm commented Apr 3, 2024

Use a pure go sqlite3 driver from https://github.com/glebarez/go-sqlite.

@alonsobm
Copy link
Author

alonsobm commented Apr 3, 2024

Seems the CI pipeline is failing because there is no enough space for some docker images. Other PRs have the same problem.

Copy link
Member

@dhui dhui left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@alonsobm if you rebase, tests should pass now
Any reason why the sqlite driver wouldn't work?

We avoid swapping out the underlying db driver and prefer to create new db drivers since some customers rely on using the same underlying db driver in their app.

@alonsobm
Copy link
Author

@alonsobm if you rebase, tests should pass now Any reason why the sqlite driver wouldn't work?

We avoid swapping out the underlying db driver and prefer to create new db drivers since some customers rely on using the same underlying db driver in their app.

Thanks for the response, main reason was to avoid cgo, I thought the sqlite driver was for a previous version of sqlite, didn't notice it was also for v3. I think we can close this PR

@dhui
Copy link
Member

dhui commented Apr 30, 2024

Closing per previous comment

@dhui dhui closed this Apr 30, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants