Add no lock parameter for Postgres #1030
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dhui
approved these changes
Apr 19, 2024
There was a problem hiding this comment.
@Ray-Barker thanks for the PR!
Could you address my comments and rebase to re-run tests?
| @@ -53,6 +53,7 @@ type Config struct { | |||
| migrationsTableName string | |||
| StatementTimeout time.Duration | |||
| MultiStatementMaxSize int | |||
| NoLock bool | |||
There was a problem hiding this comment.
Document this new parameter in the README
| @@ -453,6 +469,7 @@ func (p *Postgres) Drop() (err error) { | |||
| // Note that this function locks the database, which deviates from the usual | |||
| // convention of "caller locks" in the Postgres type. | |||
| func (p *Postgres) ensureVersionTable() (err error) { | |||
|
|
|||
There was a problem hiding this comment.
Nit: remove this unnecessary change
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Essentially a copy of Mysql no-lock parameter, but for Postgres.
Opened issue addressing this: #1001