Return ed25519 key types from their parse functions #324
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Instead of the generic crypto key types. This is done in the other parse functions as well. The code already does the type assertion.
mfridman
reviewed
Jul 20, 2023
| @@ -14,7 +13,7 @@ var ( | |||
| ) | |||
|
|
|||
| // ParseEdPrivateKeyFromPEM parses a PEM-encoded Edwards curve private key | |||
| func ParseEdPrivateKeyFromPEM(key []byte) (crypto.PrivateKey, error) { | |||
| func ParseEdPrivateKeyFromPEM(key []byte) (ed25519.PrivateKey, error) { | |||
There was a problem hiding this comment.
Given these are public functions, and the underlying types are different, I think this would be a breaking change.
We avoid breaking changes in major versions.
I do agree having parity would be nice, but not at the expense of introducing an incompatible change.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Instead of the generic crypto key types. This is done in the other parse functions as well. The code already does the type assertion.