Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

deps: Update to github.com/pelletier/go-toml/v2 v2.0.1 #9975

Merged
merged 1 commit into from Jun 6, 2022

Conversation

anthonyfok
Copy link
Member

For some reasons, dependabot did not pick up on this, probably because of the following test errors:

--- FAIL: TestEmptyTarget (0.00s)
    deployConfig_test.go:184: 
        error:
          got nil value but want non-nil
        got:
          nil
        stack:
          /mnt/easystore/git/hugo/deploy/deployConfig_test.go:184
            c.Assert(err, qt.Not(qt.IsNil))
        
--- FAIL: TestEmptyMatcher (0.00s)
    deployConfig_test.go:198: 
        error:
          got nil value but want non-nil
        got:
          nil
        stack:
          /mnt/easystore/git/hugo/deploy/deployConfig_test.go:198
            c.Assert(err, qt.Not(qt.IsNil))

due to

I ended up modifying deploy/deployConfig.go (with help from https://stackoverflow.com/questions/28447297/how-to-check-for-an-empty-struct) to get the "empty deployment target/matcher" tests work with github.com/pelletier/go-toml/v2 v2.0.1

My knowledge of Go is still rather limited, so I hope I am doing it correctly. Thanks in advance for your code reviews!

@anthonyfok anthonyfok added the dependencies Pull requests that update a dependency file label Jun 4, 2022
@anthonyfok anthonyfok requested review from jmooring and bep June 4, 2022 09:26
@bep bep merged commit 534e715 into gohugoio:master Jun 6, 2022
@github-actions
Copy link

github-actions bot commented Jun 7, 2023

This pull request has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Jun 7, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
dependencies Pull requests that update a dependency file
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants