Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update chroma goldmark-highlighting #7027

Closed
wants to merge 1 commit into from

Conversation

satotake
Copy link
Contributor

@satotake satotake commented Mar 7, 2020

@@ -5,7 +5,7 @@ require (
github.com/BurntSushi/toml v0.3.1
github.com/PuerkitoBio/purell v1.1.1
github.com/PuerkitoBio/urlesc v0.0.0-20170810143723-de5bf2ad4578 // indirect
github.com/alecthomas/chroma v0.7.1
github.com/alecthomas/chroma v0.7.2-0.20200305040604-4f3623dce67a
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't want to add non-release versions unless I really have to.

Copy link
Contributor Author

@satotake satotake Mar 7, 2020

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

OK. Let's wait for releasing it.
Should I close this and recreate then, or keep and update it?

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Up to you.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ok.
Although I don't have specific reasons, I will close this for now

@satotake satotake closed this Mar 7, 2020
satotake added a commit to satotake/hugo that referenced this pull request Apr 23, 2020
bep pushed a commit that referenced this pull request Apr 23, 2020
@github-actions
Copy link

This pull request has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Jan 22, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Additional empty line in syntax-highlighted code fences when using Windows line endings
2 participants