Change fsnotify event operation check #11432
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fsnotify v1.6.0 added a Has method that makes operation checks clearer. Direct bitwise operations require a bit more thought to parse.
|
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request takes advantage of a new feature added to fsnotify v1.6.0 that allows for checking event operations using the Has method instead of direct bitwise operations. The former may be clearer for most developers.
I'm not sure if the overhead of calling the Has method would be significant. While it seems like a good candidate for inlining by the Go compiler, I haven't been able to prove that is happening at all. Let me know your thoughts!