Skip to content

Commit

Permalink
tpl/tplimpl: Plainify title and description in schema.html
Browse files Browse the repository at this point in the history
Closes #12432
  • Loading branch information
jmooring authored and bep committed May 14, 2024
1 parent 6dbbe6d commit 92290aa
Show file tree
Hide file tree
Showing 2 changed files with 84 additions and 2 deletions.
4 changes: 2 additions & 2 deletions tpl/tplimpl/embedded/templates/schema.html
Original file line number Diff line number Diff line change
@@ -1,8 +1,8 @@
{{- with or .Title site.Title }}
{{- with or .Title site.Title | plainify }}
<meta itemprop="name" content="{{ . }}">
{{- end }}

{{- with or .Description .Summary site.Params.Description }}
{{- with or .Description .Summary site.Params.description | plainify | htmlUnescape | chomp }}
<meta itemprop="description" content="{{ . }}">
{{- end }}

Expand Down
82 changes: 82 additions & 0 deletions tpl/tplimpl/tplimpl_integration_test.go
Original file line number Diff line number Diff line change
Expand Up @@ -411,3 +411,85 @@ series: [series-1]
`<meta property="og:description" content="m n and **o** can&#39;t.">`,
)
}

// Issue 12432
func TestSchema(t *testing.T) {
t.Parallel()

files := `
-- hugo.toml --
capitalizeListTitles = false
disableKinds = ['rss','sitemap']
[markup.goldmark.renderer]
unsafe = true
[params]
description = "m <em>n</em> and **o** can't."
[taxonomies]
tag = 'tags'
-- layouts/_default/list.html --
{{ template "_internal/schema.html" . }}
-- layouts/_default/single.html --
{{ template "_internal/schema.html" . }}
-- content/s1/p1.md --
---
title: p1
date: 2024-04-24T08:00:00-07:00
lastmod: 2024-04-24T11:00:00-07:00
images: [a.jpg,b.jpg]
tags: [t1,t2]
---
a <em>b</em> and **c** can't.
-- content/s1/p2.md --
---
title: p2
---
d <em>e</em> and **f** can't.
<!--more-->
-- content/s1/p3.md --
---
title: p3
summary: g <em>h</em> and **i** can't.
---
-- content/s1/p4.md --
---
title: p4
description: j <em>k</em> and **l** can't.
---
-- content/s1/p5.md --
---
title: p5
---
`

b := hugolib.Test(t, files)

b.AssertFileContent("public/s1/p1/index.html", `
<meta itemprop="name" content="p1">
<meta itemprop="description" content="a b and c can’t.">
<meta itemprop="datePublished" content="2024-04-24T08:00:00-07:00">
<meta itemprop="dateModified" content="2024-04-24T11:00:00-07:00">
<meta itemprop="wordCount" content="5">
<meta itemprop="image" content="/a.jpg">
<meta itemprop="image" content="/b.jpg">
<meta itemprop="keywords" content="t1,t2">
`,
)

b.AssertFileContent("public/s1/p2/index.html",
`<meta itemprop="description" content="d e and f can’t.">`,
)

b.AssertFileContent("public/s1/p3/index.html",
`<meta itemprop="description" content="g h and i can’t.">`,
)

// The markdown is intentionally not rendered to HTML.
b.AssertFileContent("public/s1/p4/index.html",
`<meta itemprop="description" content="j k and **l** can&#39;t.">`,
)

// The markdown is intentionally not rendered to HTML.
b.AssertFileContent("public/s1/p5/index.html",
`<meta itemprop="description" content="m n and **o** can&#39;t.">`,
)
}

0 comments on commit 92290aa

Please sign in to comment.