-
Notifications
You must be signed in to change notification settings - Fork 4.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix/14856 #15210
Closed
Closed
Fix/14856 #15210
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Vadim Bauer <vb@container-registry.com>
Signed-off-by: AllForNothing <sshijun@vmware.com> Signed-off-by: Vadim Bauer <vb@container-registry.com>
* add build arch parameter in Makefile Add parameter BUILDARCH for make file. DB base builds pg96 for x86_64 only Signed-off-by: Wang Yan <wangyan@vmware.com> Signed-off-by: Vadim Bauer <vb@container-registry.com>
Closes goharbor#14284 Signed-off-by: He Weiwei <hweiwei@vmware.com> Signed-off-by: Vadim Bauer <vb@container-registry.com>
Signed-off-by: chlins <chlins.zhang@gmail.com> Signed-off-by: Vadim Bauer <vb@container-registry.com>
fixes goharbor#15000 It needs to double confirm that old pg is stopped before migration Signed-off-by: wang yan <wangyan@vmware.com> Signed-off-by: Vadim Bauer <vb@container-registry.com>
The robotv1 context uses the robot$ as a hardcoded prefix to identify robot account, it will raise error for a valid robotv2 account with this prefix. Update the log level to avoid the redundant logs for the default installation. Signed-off-by: Wang Yan <wangyan@vmware.com> Signed-off-by: Vadim Bauer <vb@container-registry.com>
Signed-off-by: AllForNothing <sshijun@vmware.com> Signed-off-by: Vadim Bauer <vb@container-registry.com>
Fixed goharbor#15034, as for postgres 13, the default shm size is 64MB, set to 1gb to avoid could not resize shared memory segment error. Signed-off-by: Wang Yan <wangyan@vmware.com> Signed-off-by: Vadim Bauer <vb@container-registry.com>
Signed-off-by: yunkunrao <yunkunrao@gmail.com> Signed-off-by: Vadim Bauer <vb@container-registry.com>
Signed-off-by: yunkunrao <yunkunrao@gmail.com> Signed-off-by: Vadim Bauer <vb@container-registry.com>
Signed-off-by: yunkunrao <yunkunrao@gmail.com> Signed-off-by: Vadim Bauer <vb@container-registry.com>
As from docker v20, the containerd leverages the cache when to pull a manifest, that leads to the client doesn't send the get manifest request if the image exists in local. The content trust and vul checker are only valid for get manifest request, the PR is to enable the checkers on head manifest request to handle the containerd local cache scenario. Signed-off-by: Wang Yan <wangyan@vmware.com> Signed-off-by: Vadim Bauer <vb@container-registry.com>
* 127.0.0.1 to localhost * listening net addr add ipv6 format Signed-off-by: DQ <dengq@vmware.com> Signed-off-by: Vadim Bauer <vb@container-registry.com>
Fixes goharbor#13976 for the quota exceed case, gc will print the untagged blobs for dry-run Signed-off-by: Wang Yan <wangyan@vmware.com> Signed-off-by: Vadim Bauer <vb@container-registry.com>
Signed-off-by: DQ <dengq@vmware.com> Signed-off-by: Vadim Bauer <vb@container-registry.com>
Closes goharbor#15081 Signed-off-by: He Weiwei <hweiwei@vmware.com> Signed-off-by: Vadim Bauer <vb@container-registry.com>
Signed-off-by: AllForNothing <sshijun@vmware.com> Signed-off-by: Vadim Bauer <vb@container-registry.com>
Flattening repository path components excepting the last one in replication Fixes goharbor#15072 Signed-off-by: Wenkai Yin <yinw@vmware.com> Signed-off-by: Vadim Bauer <vb@container-registry.com>
… repository Set "x-omitempty" as "false" for the pull count and artifact count of repository to avoid the missing of these properties in API response Signed-off-by: Wenkai Yin <yinw@vmware.com> Signed-off-by: Vadim Bauer <vb@container-registry.com>
Closes goharbor#14416 goharbor#14299 Signed-off-by: He Weiwei <hweiwei@vmware.com> Signed-off-by: Vadim Bauer <vb@container-registry.com>
Signed-off-by: AllForNothing <sshijun@vmware.com> Signed-off-by: Vadim Bauer <vb@container-registry.com>
Signed-off-by: danfengliu <danfengl@vmware.com> Signed-off-by: Vadim Bauer <vb@container-registry.com>
1. Fix replication namespace level issue; 2. Add UI test for replicaiton flattening. Signed-off-by: danfengliu <danfengl@vmware.com> Signed-off-by: Vadim Bauer <vb@container-registry.com>
Remove build base executable in Makefile by replacing it as an input parameter. Add add more input parameters for controlling docker pull/push to make build base process flexible for users. Signed-off-by: danfengliu <danfengl@vmware.com> Signed-off-by: Vadim Bauer <vb@container-registry.com>
…cation policy Add validation for destination namespace when creating/updating replication policy Signed-off-by: Wenkai Yin <yinw@vmware.com> Signed-off-by: Vadim Bauer <vb@container-registry.com>
The transaction will be aborted when get errors during the execution which causes the following sqls report error. This commit moves the re-getting artifact logic out of the second transaction to avoid the concurrent pushing issue Signed-off-by: Wenkai Yin <yinw@vmware.com> Signed-off-by: Vadim Bauer <vb@container-registry.com>
It would be a docker access deny failure if no logout, so add logout back to push script. Signed-off-by: danfengliu <danfengl@vmware.com> Signed-off-by: Vadim Bauer <vb@container-registry.com>
Signed-off-by: danfengliu <danfengl@vmware.com> Signed-off-by: Vadim Bauer <vb@container-registry.com>
Closes goharbor#15041 Signed-off-by: He Weiwei <hweiwei@vmware.com> Signed-off-by: Vadim Bauer <vb@container-registry.com>
Docker access auth has be done before push image script, hence docker login and logout is nolonger needed. Signed-off-by: danfengliu <danfengl@vmware.com> Signed-off-by: Vadim Bauer <vb@container-registry.com>
Signed-off-by: danfengliu <danfengl@vmware.com> Signed-off-by: Vadim Bauer <vb@container-registry.com>
…oharbor#4719 Signed-off-by: Vadim Bauer <vb@container-registry.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This should resolve #14856 or make it very unlikely to appear same was also done in the pasts with #4719